-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add Kurdish language option to UI #4210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As is, this errors when the language is selected. Probably because of the underscore in the language name. |
|
Thanks for the PR. I added the language in weblate , so it is probably a setting there. Would need to check if it is able to use what you suggest here instead |
|
Like this it works and follows the ISO naming convention. Changed from Do you have to change something in Weblate for this to show up? Or does it auto update if merged? |
|
Thanks for the fixes. Now I can pull the code back into weblate. Then I'll need to check if the files end up in the correct place. |
|
@BudsieBuds now the language appears as 'Kurdish' and not as the Iraqi variant the author originally suggested. I guess the proper fix would be to name the folder |
|
@jekkos I overlooked this and assumed it was Kurdish. After some research, I found that adding the country code (ISO 3166) isn’t necessary. Since Central Kurdish lacks a two-letter code under ISO 639-1, I've switched to using the three-letter code from ISO 639-3 instead. The country code may be added in the future if there are more variants. Updated for merging here: #4211. 👍 |
|
Kurds primarily speak three different dialects: kmr – Northern Kurdish (it might be worth considering including this if someone requests it), ckb – Central Kurdish (this is the dialect I speak), sdh – Southern Kurdish. As for country codes, they are not necessary since the same dialects are spoken across different countries. Conclusionkmr for Kurdish (Northern) |
|
I chose the term Central Kurdish because it is used by the Language Coding Agency for ISO 639-3. See here: https://iso639-3.sil.org/code/ckb |
|
Initially, when switching to Kurdish, users often scroll down to the letter K to find it. It would be much easier to rename it as => Kurdish (Central). |
|
I reexamined the naming conventions and have updated several language names to enhance discoverability. Changes will be live if #4218 is merged. |

Makes the Kurdish language selectable in the UI. As requested here: #4209.
@jekkos I do wonder why this language was added as ckb_IQ instead of the ISO 639-1 standard used for all other languages, in this case being
ku. If you decide to change this for consistency, you should also change the following:app/Config/App.php
ckb_IQ',to'ku',app/Helpers/locale_helper.php
'ckb_IQ:centralkurdish' => 'Central Kurdish (Iraq)',to'ku:kurdish' => 'Kurdish',