Skip to content

Conversation

@BudsieBuds
Copy link
Member

Makes the Kurdish language selectable in the UI. As requested here: #4209.

@jekkos I do wonder why this language was added as ckb_IQ instead of the ISO 639-1 standard used for all other languages, in this case being ku. If you decide to change this for consistency, you should also change the following:

app/Config/App.php
ckb_IQ', to 'ku',

app/Helpers/locale_helper.php
'ckb_IQ:centralkurdish' => 'Central Kurdish (Iraq)', to 'ku:kurdish' => 'Kurdish',

@BudsieBuds
Copy link
Member Author

As is, this errors when the language is selected. Probably because of the underscore in the language name.

@BudsieBuds BudsieBuds marked this pull request as draft April 13, 2025 19:05
@jekkos
Copy link
Member

jekkos commented Apr 13, 2025

Thanks for the PR. I added the language in weblate , so it is probably a setting there. Would need to check if it is able to use what you suggest here instead

@BudsieBuds
Copy link
Member Author

Like this it works and follows the ISO naming convention. Changed from ckb_IQ to ku fixed the error. Had to add the empty keys to solve new errors. Also added some missing language files.

Do you have to change something in Weblate for this to show up? Or does it auto update if merged?

@BudsieBuds BudsieBuds marked this pull request as ready for review April 13, 2025 21:12
@jekkos jekkos merged commit a62bef5 into master Apr 14, 2025
3 of 4 checks passed
@jekkos
Copy link
Member

jekkos commented Apr 14, 2025

Thanks for the fixes. Now I can pull the code back into weblate. Then I'll need to check if the files end up in the correct place.

@jekkos
Copy link
Member

jekkos commented Apr 14, 2025

@BudsieBuds now the language appears as 'Kurdish' and not as the Iraqi variant the author originally suggested. I guess the proper fix would be to name the folder ckb-IQ as we do with nl-BE and nl-NL? wdyt

@BudsieBuds BudsieBuds deleted the add-language-ckb branch April 15, 2025 00:20
@BudsieBuds
Copy link
Member Author

@jekkos I overlooked this and assumed it was Kurdish. After some research, I found that adding the country code (ISO 3166) isn’t necessary. Since Central Kurdish lacks a two-letter code under ISO 639-1, I've switched to using the three-letter code from ISO 639-3 instead. The country code may be added in the future if there are more variants. Updated for merging here: #4211. 👍

@OmerQadirFM
Copy link
Contributor

OmerQadirFM commented Apr 15, 2025

Kurds primarily speak three different dialects:

kmr – Northern Kurdish (it might be worth considering including this if someone requests it),
spoken in mainly Turkey, Iran, Iraq, Syria, Armenia, Azerbaijan.

ckb – Central Kurdish (this is the dialect I speak),
spoken in mainly in Iraq, Iran

sdh – Southern Kurdish.
spoken in mainly in Iran, Iraq

As for country codes, they are not necessary since the same dialects are spoken across different countries.

Conclusion

kmr for Kurdish (Northern)
ckb for Kurdish (Central)

@OmerQadirFM
Copy link
Contributor

To ensure easier finding, change it from Central Kurdish to Kurdish (Central).

image

@BudsieBuds
Copy link
Member Author

I chose the term Central Kurdish because it is used by the Language Coding Agency for ISO 639-3. See here: https://iso639-3.sil.org/code/ckb

@OmerQadirFM
Copy link
Contributor

OmerQadirFM commented Apr 16, 2025

Initially, when switching to Kurdish, users often scroll down to the letter K to find it. It would be much easier to rename it as => Kurdish (Central).

@BudsieBuds
Copy link
Member Author

I reexamined the naming conventions and have updated several language names to enhance discoverability. Changes will be live if #4218 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants