Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
MS365認証(Microsoft Graph Transport)を使用したメール送信時に、Reply-To(返信先)アドレスを適切に設定する機能を追加しました。
変更の背景・目的
MS365認証でメール送信を行う際、OAuth2設定の送信者アドレスと異なるFromアドレスを使用する場合、受信者が返信した際に適切なアドレスに返信されるようにする必要があります。この変更により、FromアドレスがOAuth2設定と異なる場合、自動的にReply-Toヘッダーが設定されるようになります。
主な変更内容
機能追加
MicrosoftGraphTransport::convertToGraphMessage()メソッドにReply-To設定ロジックを追加テスト追加
以下の3つのテストケースを追加し、動作を保証しました:
レビュー指摘対応
以下の改善を実施しました:
testReplyToNotSetWhenFromIsNull(): Fromがnullの場合testReplyToNotSetWhenFromIsEmpty(): Fromが空配列の場合レビュー完了希望日
特になし
関連PR / Issues
なし
参考情報
なし
DB変更
チェックリスト