Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
FAQプラグインのカテゴリ別表示テンプレートで発生していたアコーディオン制御の不具合を修正しました。
※クライアントより問い合わせあり
変更の背景・目的
カテゴリ別表示において、以下の意図しない動作が発生していました:
参考(問題事象の再現画像:両カテゴリ共に展開されてしまっている)
変更内容
resources/views/plugins/user/faqs/category/faqs.blade.phpを修正し、全FAQ項目が統一されたaccordion親要素を参照するよう改善しました。修正箇所:
<div class="accordion" id="accordionFaq{{$frame_id}}">を追加</div>を追加動作改善:
レビュー完了希望日
特になし
関連PR/Issues
なし
参考情報
Bootstrap アコーディオンの標準動作に準拠した修正
DB変更の有無
チェックリスト