Skip to content

Override images in env vars (#152) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aliok merged 1 commit into from
Mar 30, 2020
Merged

Override images in env vars (#152) #8

aliok merged 1 commit into from
Mar 30, 2020

Conversation

@aliok
Copy link

@aliok aliok commented Mar 30, 2020

(cherry picked from commit eaf1553)

Issue to be fixed

Fixes #

Proposed Changes

Release Note

openshift-ci-robot
openshift-ci-robot reviewed Mar 30, 2020
View reviewed changes
Copy link

@openshift-ci-robot openshift-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliok: 0 warnings.

Details

In response to this:

(cherry picked from commit eaf1553)

Issue to be fixed

Fixes #

Proposed Changes

Release Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matzew
matzew approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@aliok
Copy link
Author

aliok commented Mar 30, 2020

/retest

@aliok
Copy link
Author

aliok commented Mar 30, 2020

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 30, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aliok, matzew
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok aliok merged commit 851fd84 into openshift-knative:release-0.13.1 Mar 30, 2020
@aliok aliok deleted the openshift-release-0.13-cherrypick-img-override branch March 30, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@openshift-ci-robot openshift-ci-robot openshift-ci-robot left review comments

@matzew matzew matzew approved these changes

Assignees

@matzew matzew

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aliok @openshift-ci-robot @matzew