Skip to content

Conversation

@sayan-biswas
Copy link
Contributor

Changes:

  • Update go.mod to 1.23
  • Update Dockerfiles and CI

@openshift-ci openshift-ci bot requested review from divyansh42 and jkhelil May 21, 2025 19:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2025
@sayan-biswas sayan-biswas force-pushed the update-golang branch 4 times, most recently from 536880d to ed72d16 Compare May 21, 2025 23:26
@sayan-biswas
Copy link
Contributor Author

/test verify

@sayan-biswas sayan-biswas force-pushed the update-golang branch 3 times, most recently from eda7304 to 731c095 Compare May 23, 2025 07:20
Changes:
- Update go.mod to 1.23
- Update Dockerfiles and CI
@sayan-biswas
Copy link
Contributor Author

/override "Red Hat Konflux / conforma-source-to-image / source-to-image-rhel8"

The conforma test compains about hermetic build, which is enabled. Will look at and fix in a different PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2025

@sayan-biswas: Overrode contexts on behalf of sayan-biswas: Red Hat Konflux / conforma-source-to-image / source-to-image-rhel8

Details

In response to this:

/override "Red Hat Konflux / conforma-source-to-image / source-to-image-rhel8"

The conforma test compains about hermetic build, which is enabled. Will look at and fix in a different PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sayan-biswas sayan-biswas changed the title Update golang to 1.23 BUILD-1441: Update golang to 1.23 May 23, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 23, 2025

@sayan-biswas: This pull request references BUILD-1441 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Changes:

  • Update go.mod to 1.23
  • Update Dockerfiles and CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sayan-biswas sayan-biswas changed the title BUILD-1441: Update golang to 1.23 [BUILD-1441] Update golang to 1.23 May 23, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 23, 2025
@openshift-ci-robot
Copy link

@sayan-biswas: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Changes:

  • Update go.mod to 1.23
  • Update Dockerfiles and CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sayan-biswas sayan-biswas changed the title [BUILD-1441] Update golang to 1.23 BUILD-1441: Update golang to 1.23 May 23, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 23, 2025

@sayan-biswas: This pull request references BUILD-1441 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Changes:

  • Update go.mod to 1.23
  • Update Dockerfiles and CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sayan-biswas
Copy link
Contributor Author

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2025

@sayan-biswas: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@psrvere
Copy link
Contributor

psrvere commented May 23, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psrvere, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [psrvere,sayan-biswas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2025

@sayan-biswas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 26d3bd0 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 506cbbe into openshift:master May 23, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants