Skip to content

Conversation

@avinal
Copy link
Member

@avinal avinal commented Apr 23, 2025

Changes

  • added CEL expressions
  • added remote reference for pipelines

@openshift-ci openshift-ci bot requested review from jkhelil and sayan-biswas April 23, 2025 10:29
@avinal avinal force-pushed the appstudio-source-to-image-rhel9 branch from 11469b5 to 8ed2240 Compare April 23, 2025 10:32
Copy link
Contributor

@sayan-biswas sayan-biswas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Needs to change the component name though.

@avinal avinal force-pushed the appstudio-source-to-image-rhel9 branch from 8ed2240 to 7447196 Compare April 24, 2025 11:11
@sayan-biswas
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2025
@sayan-biswas sayan-biswas force-pushed the appstudio-source-to-image-rhel9 branch 2 times, most recently from a6dfff1 to 9a4a664 Compare May 19, 2025 18:34
- added CEL expressions
- added remote reference for pipelines
- Added service accounts

Signed-off-by: Avinal Kumar <[email protected]>
@sayan-biswas sayan-biswas force-pushed the appstudio-source-to-image-rhel9 branch from 9a4a664 to 1fbf9cf Compare May 20, 2025 10:00
@sayan-biswas
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2025

@avinal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 1fbf9cf link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sayan-biswas
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sayan-biswas
Copy link
Contributor

/override "Red Hat Konflux / source-to-image-enterprise-contract / pr group"
/override "Red Hat Konflux / conforma-source-to-image / pr group"
/override "Red Hat Konflux / source-to-image-enterprise-contract / source-to-image-rhel9"

these tests are obsolete and removed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 21, 2025

@sayan-biswas: Overrode contexts on behalf of sayan-biswas: Red Hat Konflux / conforma-source-to-image / pr group, Red Hat Konflux / source-to-image-enterprise-contract / pr group, Red Hat Konflux / source-to-image-enterprise-contract / source-to-image-rhel9

Details

In response to this:

/override "Red Hat Konflux / source-to-image-enterprise-contract / pr group"
/override "Red Hat Konflux / conforma-source-to-image / pr group"
/override "Red Hat Konflux / source-to-image-enterprise-contract / source-to-image-rhel9"

these tests are obsolete and removed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 5ebc50d into openshift:master May 21, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants