Skip to content

Improve stacktrace to fix tech debts #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 1 commit into from
Oct 30, 2023
Merged

Improve stacktrace to fix tech debts #1132

openshift-ci merged 1 commit into from
Oct 30, 2023

Conversation

@divyansh42
Copy link
Contributor

@divyansh42 divyansh42 commented Oct 27, 2023

No description provided.

@divyansh42
Copy link
Contributor Author

divyansh42 commented Oct 27, 2023

/cc @coreydaley

@coreydaley
Copy link

coreydaley commented Oct 27, 2023

/lgtm
/approve

coreydaley
coreydaley reviewed Oct 27, 2023
View reviewed changes
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@divyansh42
Copy link
Contributor Author

divyansh42 commented Oct 27, 2023

/retest

@divyansh42 divyansh42 force-pushed the fix-tech-debt branch 2 times, most recently from 474f164 to 8b21977 Compare October 27, 2023 14:50
@divyansh42
Copy link
Contributor Author

divyansh42 commented Oct 27, 2023

@coreydaley fixed formatting error as well.

coreydaley
coreydaley suggested changes Oct 30, 2023
View reviewed changes
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

@divyansh42: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 4894b3d link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@coreydaley
Copy link

coreydaley commented Oct 30, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, divyansh42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@openshift-ci openshift-ci bot merged commit 770cbc2 into openshift:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorvajagtap apoorvajagtap Awaiting requested review from apoorvajagtap

1 more reviewer

@coreydaley coreydaley coreydaley requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@coreydaley coreydaley

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@divyansh42 @coreydaley