Skip to content

Updating dependencies #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-ci merged 2 commits into from
Oct 18, 2023
Merged

Updating dependencies #1128

openshift-ci merged 2 commits into from
Oct 18, 2023

Conversation

@coreydaley
Copy link

@coreydaley coreydaley commented Oct 17, 2023

No description provided.

@coreydaley
Copy link
Author

coreydaley commented Oct 17, 2023

/assign @apoorvajagtap @divyansh42

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@coreydaley
Copy link
Author

coreydaley commented Oct 17, 2023

It is fine that the security test failed for now, that is a known issue.

@divyansh42
Copy link
Contributor

divyansh42 commented Oct 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@coreydaley
Copy link
Author

coreydaley commented Oct 18, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@coreydaley
Copy link
Author

coreydaley commented Oct 18, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@divyansh42
Copy link
Contributor

divyansh42 commented Oct 18, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@coreydaley
Copy link
Author

coreydaley commented Oct 18, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@divyansh42
Copy link
Contributor

divyansh42 commented Oct 18, 2023

/lgtm

@coreydaley
Copy link
Author

coreydaley commented Oct 18, 2023

/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, divyansh42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

@coreydaley: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 5f152d3 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 574a264 into openshift:master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoorvajagtap apoorvajagtap Awaiting requested review from apoorvajagtap

@jkhelil jkhelil Awaiting requested review from jkhelil

Assignees

@divyansh42 divyansh42

@apoorvajagtap apoorvajagtap

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coreydaley @divyansh42 @apoorvajagtap