Skip to content

Updating release code to use go1.18 #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coreydaley merged 1 commit into from
Dec 14, 2022
Merged

Updating release code to use go1.18 #1101

coreydaley merged 1 commit into from
Dec 14, 2022

Conversation

@coreydaley
Copy link

@coreydaley coreydaley commented Dec 14, 2022

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2022

@coreydaley: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@coreydaley coreydaley merged commit 78363ee into openshift:master Dec 14, 2022
@omajid
Copy link

omajid commented Feb 6, 2023

This reverted #1080. Is there any plan to re-enable it?

@coreydaley
Copy link
Author

coreydaley commented Feb 6, 2023

Those images would not build.

@omajid
Copy link

omajid commented Feb 6, 2023

cc @tmds who initially contributed #1080

@tmds
Copy link
Contributor

tmds commented Feb 6, 2023 •
edited
Loading

I don't speak Go, in #1080 I literally did what I was told to do here.

@coreydaley would there be a way to acquire aarch64 builds of s2i?
This gets shipped in containers for OpenShift, doesn't it?

@tmds
Copy link
Contributor

tmds commented Feb 6, 2023

I think OpenShift uses this image (or one like it). It's available for x64, amd64, ppc64le and s390x.

@omajid if there is no (easy) way to get an aarch64 build, we could use this image.

@tmds tmds mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coreydaley @omajid @tmds