Skip to content
This repository was archived by the owner on Dec 1, 2022. It is now read-only.

Conversation

@markusthoemmes
Copy link

Disable this E2E test as it's not going to work if the v1beta1 API is disabled. Going to work with upstream to solve this differently (maybe through a testing flag).

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 1, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2019
@nak3
Copy link

nak3 commented Jul 1, 2019

lgtm 👍 (I wondered that we need to exclude TestV1beta1Rejection as well, but it looks like the test could be passed without exclude.)

@nak3
Copy link

nak3 commented Jul 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b0cf9ab into release-next Jul 1, 2019
@markusthoemmes markusthoemmes deleted the markus-patch-beta branch July 8, 2019 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants