apply pixelDensityRatio after flip #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangilman
approved these changes
Feb 24, 2020
Member
iangilman
left a comment
iangilman
left a comment
There was a problem hiding this comment.
Nice! That certainly seems like the right solution to me. Thank you for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a super specific scenario that was failing, but looking at some of the open issues maybe there is a wider audience for this. Possibly #1695
In my case, a flipped and rotated image with
compositeOperation='lighter'was rendering improperly when on high pixel density monitors. (Retina displays). It was fine otherwise.The issue seems to have been with the order of operations between applying a multiplier for pixel density, and reversing the x-coordinate polarity. Before this patch, the numbers shoot off in the wrong direction.
Happy to discuss, if you see issues or I am completely off the mark, as it's my first PR here!