Skip to content

[DRAFT] Flatten CSG tree to let more lazy unions bubble up to the top#4561

Closed
ochafik wants to merge 12 commits intoopenscad:masterfrom
ochafik:flatten
Closed

[DRAFT] Flatten CSG tree to let more lazy unions bubble up to the top#4561
ochafik wants to merge 12 commits intoopenscad:masterfrom
ochafik:flatten

Conversation

@ochafik
Copy link
Contributor

@ochafik ochafik commented Mar 18, 2023

This is a rehash of #3637, hopefully more likely to be productionized.

Goals:

Note that I've improved Manifold's tree flattening in elalish/manifold#368. We could potentially ask Manifold for a lazy top-level union instead of its full rendering (it keeps a lazy CSG AST under the hood), which could be a better approach than this PR (it might still need to deal with the issue of transforms precision). Still, I wanted to get this draft PR out there as it works even w/o Manifold.

@pca006132
Copy link
Member

We could potentially ask Manifold for a lazy top-level union instead of its full rendering

Yeah, we can just provide a GetMeshes function that returns a list of meshes that should be unioned together.

@ochafik ochafik closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants