[fast-csg] Port minkowski to the hybrid fast-csg world#4113
Merged
t-paul merged 7 commits intoopenscad:masterfrom Feb 13, 2022
Merged
[fast-csg] Port minkowski to the hybrid fast-csg world#4113t-paul merged 7 commits intoopenscad:masterfrom
t-paul merged 7 commits intoopenscad:masterfrom
Conversation
added 6 commits
February 11, 2022 19:49
Saves ~10-20% off a simple example like this:
$fn=50;
minkowski() {
difference() {
hull() {
translate([3, 0, 0])
cube(0.5, center=true);
cube(1, center=true);
}
translate([0, 0, 0])
sphere(1);
}
sphere(1);
}
Change of expressions: i->opposite()->vertex()->point() -> p.point(p.target(p.opposite(i))) i->vertex()->point(), -> p.point(p.target(i)) i->next()->vertex()->point()); -> p.point(p.target(p.next(i)))) i->opposite()->next()->vertex()->point()) -> p.point(p.target(p.next(p.opposite(i))) f->facet_begin() -> p.halfedge(f) he->opposite()->facet() -> p.face(p.opposite(he))
…on const) In the hybrid minkowski rewrite, we'll save some copies thanks to this
ochafik
changed the title
8 tasks
t-paul
approved these changes
Feb 13, 2022
ochafik
pushed a commit
to ochafik/openscad
that referenced
this pull request
Mar 4, 2022
…erimental feature b/c it's slower!!
Benchmarked:
hyperfine -L remesh ",--enable=fast-csg-remesh,--enable=fast-csg-remesh-predictibly" "./buildRelease/OpenSCAD.app/Contents/MacOS/OpenSCAD mnk.scad --enable=fast-csg --enable=fast-csg-trust-corefinement -o out.stl {remesh}"
With mnk.scad coming from openscad#4113
Mean : 38s (Baseline), 25s (remesh), 32s (remesh-predictibly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saves ~40% render time off a simple example like this compared to the last snapshot (with
--enable=fast-csg --enable=fast-csg-trust-corefinement), and 18x faster than withoutfast-csg:Notes: