[fast-csg] Support for upcoming CGAL remeshing#4107
Closed
ochafik wants to merge 4 commits intoopenscad:masterfrom
Closed
[fast-csg] Support for upcoming CGAL remeshing#4107ochafik wants to merge 4 commits intoopenscad:masterfrom
ochafik wants to merge 4 commits intoopenscad:masterfrom
Conversation
Enable with ENABLE_CGAL_REMESHING Currently incubated in CGAL/cgal#5461, scheduled for CGAL 5.5
This was referenced Feb 12, 2022
This was referenced Feb 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: #4117 (custom remeshing) might be a better option if it graduates
Using CGAL/cgal#5461 (
remesh_planar_patchesplanned for CGAL 5.5) fixes performance issues caused by the worst-case increases of facets during corefinements.The following files go from astronomically slow w/
fast-csgto 4-5x faster than the baseline:The fix was originally suggested by @sloriot (author of both corefinement functions & that remesh PR) in #3641 (comment)
Here are instructions to build locally with both this PR and the CGAL one it depends on.