Refactor existing code to prepare for fast-csg#3961
Merged
t-paul merged 12 commits intoopenscad:masterfrom Feb 3, 2022
Merged
Conversation
added 11 commits
October 28, 2021 05:51
…(Copy_polyhedron_to uses a new CGALUtils::getConverter helper)
…ew CGALCache::acceptsGeometry predicate.
…pplyMinkowski, applyOperator3D, applyUnion3D}
Added CGALUtils::{getGeometryAsPolySet, convertNefToPolyhedron, getGeometryAsNefPolyhedron} helpers in the process, which simplifies code in GeometryEvaluator.
…ric of the kernel type
Adding Geometry::{transform, resize} (already part of PolySet & CGAL_Nef_polyhedron) and ResultObject::asMutableGeometry helps simplify GeometryEvaluator.
Contributor
Author
|
@t-paul @thehans could you guys take a look at this one? It looks hopefully less daunting if you look at the individual commits, which I've tried to summarize in commit messages. Happy to split it in more PRs but hoped I could bundle the (hopefully) least contentious changes to prepare for the new stuff :-D |
t-paul
approved these changes
Feb 3, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes prepare the ground for #3641 and mostly don't add new helpers that are specific to fast-csg
Note: didn't realize force-pushing in the branch would close #3960, removed the invert_orientation and use_grid params (ochafik@c1b60f5) as they're no longer needed in the upcoming fast-csg codebase)