Change CGAL Union to join least complex geometries first.#3121
Merged
thehans merged 1 commit intoopenscad:masterfrom Nov 10, 2019
Merged
Change CGAL Union to join least complex geometries first.#3121thehans merged 1 commit intoopenscad:masterfrom
thehans merged 1 commit intoopenscad:masterfrom
Conversation
Update progress more regularly during union.
kintel
approved these changes
Nov 9, 2019
Member
kintel
left a comment
kintel
left a comment
There was a problem hiding this comment.
Looks good!
I wonder if such an optimization really belongs in CGAL itself, but this works for us!
13 tasks
thehans
added a commit
to thehans/openscad
that referenced
this pull request
Dec 16, 2019
kintel
pushed a commit
that referenced
this pull request
Dec 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses a priority_queue (min heap) sorted by number of face(t)s in each geometry. So the two least complex objects are always merged first. Temporary results go back into the priority queue so it adapts as complexity changes. The queue is also secondarily sorted by
node.progress_markwhen complexity matches, which should act as a stable sort.Reasoning for keeping the sort stable is based on the assumption/heuristic that consecutive sibling nodes are likely to be close to each other in space, which is more likely to cause reduction in complexity for example in a loop of identical translated objects.
Also change to progress bar update during union.
For issue #1234