Upgrade CGAL from 4.11 to 5.2#3
Closed
ochafik wants to merge 3 commits intoopenscad:openscad-snapshot-buildfrom
Closed
Upgrade CGAL from 4.11 to 5.2#3ochafik wants to merge 3 commits intoopenscad:openscad-snapshot-buildfrom
ochafik wants to merge 3 commits intoopenscad:openscad-snapshot-buildfrom
Conversation
… openscad-snapshot-build
Note: CGAL examples now live in a different package so added a simplistic test instead.
Member
|
I'll import the change to a separate branch, so the build branches can be just MXE master + merges of separate changes. I'm not sure this is possible via github, to PR against a new branch. |
t-paul
approved these changes
Feb 10, 2021
Author
|
Didn't realize master was pristine, sent #4 in case it's easier to merge |
t-paul
force-pushed
the
openscad-snapshot-build
branch
from
a890473 to
367d3c3
Compare
Member
|
Merged to new openscad-snapshot-build branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: CGAL examples now live in a different package so added a simplistic test instead.
Tested this change in CI of openscad/openscad#3641, which needs CGAL 5.1+ to speed up rendering.