Repository navigation
fix(kubernetes): skip pause dispatch for an already Paused BatchSandbox - #2082
Merged
Merged
Conversation
A generation bump on a Paused BatchSandbox with spec.pause=true (for example a renew-only spec change) was treated as a new pause request: handlePause ran again and moved the phase back to Pausing, creating a new snapshot. Return unhandled when the phase is already Paused. Fixes opensandbox-group#2080
drakeo338
requested review from
Generalwin,
Pangjiping,
Spground,
fengcone,
hittyt,
kevinlynx and
ninan-nn
as code owners
September 30, 2026 01:25
github-actions
Bot
added
component/k8s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2080.
Summary
Renewing a Paused BatchSandbox bumps its generation. dispatchPauseResume then treated spec.pause=true as a new pause request and ran handlePause, which needs a running source pod. There is none, so the sandbox went to Failed with PauseFailed/PodNotFound. The dispatcher now skips the pause when the phase is already Paused.
Testing
Only the new controller unit test was run, and it fails on the base and passes with the fix. Nothing else was run.
Breaking Changes
Checklist