-
-
Notifications
You must be signed in to change notification settings - Fork 531
Upgrade to guice-4.1 and guice-multibindings-4.1 #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This also requires adding guava, which is no longer shipped with guice.
|
The build failure is a bit perplexing. I'm not sure why ant wouldn't find one of its jars all of a sudden. |
|
The ant failure seems related to this: travis-ci/travis-ci#7706 |
|
I see other pull request builds have failed for the same reason. Perhaps we should merge even with this failure. The jar builds fine. |
|
@tibbe |
|
I expect all of our builds to run into problems untill travis-ci/travis-ci#7706 is fixed. |
|
Closing and re-opening to trigger Travis re-run. |
|
Yea, no doubt fixing travis-ci/travis-ci#7706 would fix our issue, but their repo has 1.2k+ issues, so I'm not holding my breath. Heeeeence the workaround. Also, to clarify, once #350 is accepted and merged, you'll have to merge / rebase onto it to fix the tests here. |
|
The project has upgraded juice and guava libraries as part of #556 -- including functional java 11 support. |
This also requires adding guava, which is no longer shipped with guice.