Skip to content

Conversation

@tibbe
Copy link
Contributor

@tibbe tibbe commented Jun 6, 2017

This also requires adding guava, which is no longer shipped with guice.

This also requires adding guava, which is no longer shipped
with guice.
@tibbe
Copy link
Contributor Author

tibbe commented Jun 6, 2017

I've tested on Windows 10 against both JDK 8 & 9. HiDPI now works with JDK 9 (the --permit-illegal-access VM flag is required for JDK 9 at the moment).

Before:

jdk-8

After:

jdk-9

@tibbe
Copy link
Contributor Author

tibbe commented Jun 6, 2017

The build failure is a bit perplexing. I'm not sure why ant wouldn't find one of its jars all of a sudden.

@tibbe
Copy link
Contributor Author

tibbe commented Jun 6, 2017

The ant failure seems related to this: travis-ci/travis-ci#7706

@tibbe
Copy link
Contributor Author

tibbe commented Jun 6, 2017

I see other pull request builds have failed for the same reason. Perhaps we should merge even with this failure. The jar builds fine.

@teyrana
Copy link
Member

teyrana commented Jun 11, 2017

@tibbe
FYI, This error is causing issues on other openrocket branches and PRs as well.

@teyrana
Copy link
Member

teyrana commented Jun 11, 2017

@tibbe
Also, PR #350 addresses some of the Travis build issues, by triggering a build on Ubuntu 14.04 (instead of Ubuntu 12.04 (!!))

@tibbe
Copy link
Contributor Author

tibbe commented Jun 11, 2017

I expect all of our builds to run into problems untill travis-ci/travis-ci#7706 is fixed.

@tibbe tibbe closed this Jun 11, 2017
@tibbe
Copy link
Contributor Author

tibbe commented Jun 11, 2017

Closing and re-opening to trigger Travis re-run.

@tibbe tibbe reopened this Jun 11, 2017
@teyrana
Copy link
Member

teyrana commented Jun 11, 2017

Yea, no doubt fixing travis-ci/travis-ci#7706 would fix our issue, but their repo has 1.2k+ issues, so I'm not holding my breath. Heeeeence the workaround.

Also, to clarify, once #350 is accepted and merged, you'll have to merge / rebase onto it to fix the tests here.

@teyrana
Copy link
Member

teyrana commented Mar 19, 2020

The project has upgraded juice and guava libraries as part of #556 -- including functional java 11 support.
This pull request is now superseded.

@teyrana teyrana closed this Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants