Calculate whether CD is being overridden by an ancestor as needed, instead of maintaining in a boolean variable #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould send an AERODYNAMIC_CHANGE (instead of a BOTH_CHANGE for all three)
… is overridden by an ancestor, compute as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue in #2745 is that when a new component is added to the component tree and its parent's CD is being overridden by an ancestor, the new component isn't getting marked as also being overridden by an ancestor. Rather than try to track down why, this PR takes the slightly more robust approach of eliminating the boolean and determining whether a component's CD is being overridden as needed.
Fixes #2745