[#2725] Include assembly copies in motor count display #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string addition Previously, because count is an int, Chars.TIMES was interpreted as an int (215), so the formatted String would be e.g. 217A-3 instead of 2xA-3...
Contributor
|
Thank you! You're on quite a roll lately. |
Member
Author
I have a paradoxical way of life; I'm very busy at work, so I need more distraction. That's how I ended up joining OpenRocket in the first place, when I was doing my uni exams. Also, it took a while to finish #2738, so now that I'm "freed" from that, I can tackle smaller issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2725.
Parallel booster staging example design:
Changed booster inner tube to 3-motor cluster:
No cluster and only one instance:
Note that there I discovered a bug while working on this (which was already present in 23.09). When opening the "Pods--powered with recovery deployment" example design, for the last flight config, the"A10-3" motor displayed as "217A10-3". The booster stage in that config has 2 A10-3 motors, which should display "2× A10-3". However, the '×' symbol is coded using
Chars.TIMES(u00D7). In the motor config display code, there was this:count + Chars.TIMES + " " + motorData. But, sincecountis an integer,Chars.TIMESwas also interpreted as an int (=215), instead of the '×' char. So you just did an integer sum... The solution was to force String summation:"" + count + Chars.TIMES + " " + motorData.