Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Mar 8, 2025

This PR fixes #2656 and fixes #2654 by completely rewriting the UI of the multi-level wind input. Previously, I attempted to put everything in a JTable. However, this solution was not flexible and required some hacks, which caused issues in units and decimal rounding. The new solution is to place the input in a dedicated dialog, which includes the wind profile visualization by default.

The multi-level panel in the sim dialog contains an overview of the wind levels:
image

Demo:

Screen.Recording.2025-03-09.at.00.02.28.mp4

Notable changes:

  • Unit selectors are in the headers and affect all rows, instead having one selector for each row (doesn't make much sense to want to change individual cell units)
  • Profile visualization is embedded in the wind edit dialog and dynamically responds to the wind table (highlight the selected row dot, update the units)
  • Added tooltip information to the profile visualization dots
  • Make it more clear that rows are resorted according to altitude. The moved row and its previous and next row are highlighted in a yellow color. Also when adding a new row and deleting a row, the highlighting is applied.
  • Added a "Reset levels" button to reset the table back to its default state

And a bunch of other improvements.


This PR also adds a new "Wind direction" flight data type. It didn't make sense before multi-level wind to include this (it remained constant), but for multi-level winds it can change throughout the flight.

@SiboVG
Copy link
Member Author

SiboVG commented Mar 9, 2025

We received feedback from TRF that it was unclear whether the altitude was referenced to ground or to mean sea level. Some users also wanted AGL, others wanted MSL. Therefore, I added a commit to allow you to select MSL or AGL referencing:

Screen.Recording.2025-03-10.at.00.05.02.mov

@SiboVG SiboVG merged commit 2e8b0c9 into openrocket:unstable Mar 11, 2025
1 check passed
@SiboVG SiboVG deleted the issue-2656-3 branch March 11, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant