[#1667] Eliminate window ghosting on Windows!! #2723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These JVM arguments bypass the window ghosting glitch, see skylot/jadx#2225
Contributor
|
I'm gonna have to try this and see if it improves any of the other (far less serious) problems on MacOS. |
Member
Author
If you want to test this, you have to either run from my branch using From what I've read, the arguments should have minimal influence on other OS'es. |
Contributor
|
Oh, in that case I guess I'll just wait. Not a big deal either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1667, the infamous window ghosting bug for Windows users. The fix involves adding these JVM arguments when running the JAR, as taken from here:
The fix has been confirmed by users CoreCount and Catalyst on the r/rocketry server, thanks for the help!
Today is a good day :)