Skip to content

Conversation

@JonathanDeLaCruzEncora
Copy link
Contributor

This change fixes the issue #2146 where the Rocket Config Dialog that opens up when opening an example is not focused.

The same was happening when opening it in full screen mode, so now it is focused when it opens and it can be closed with the 'esc' key or modified.

The change is just requesting focus from the Design Name text field component.

@neilweinstock
Copy link
Contributor

neilweinstock commented Feb 19, 2025

This is a nice little change, thank you for the contribution!

@SiboVG SiboVG linked an issue Feb 19, 2025 that may be closed by this pull request
@SiboVG
Copy link
Member

SiboVG commented Feb 20, 2025

Thanks for the change. Unfortunately, I'm still experiencing issue #2146 on my machine...

@JonathanDeLaCruzEncora
Copy link
Contributor Author

Sadly I am not able to replicate the issue 🤔, if there is any additional information to provide I'll look into it

@SiboVG
Copy link
Member

SiboVG commented Feb 20, 2025

Sadly I am not able to replicate the issue 🤔, if there is any additional information to provide I'll look into it

Not really, it seems very specific to my machine/setup. I have 2 identical MacBook Pros, but only one of them suffers from this issue...

@SiboVG
Copy link
Member

SiboVG commented Mar 13, 2025

@JonathanDeLaCruzEncora I finally got around to testing this on my machine. The issue was that the ComponentConfigDialog.showDialog code in BasicFrame should have been wrapped in a SwingUtilities.invokeLater(() to ensure proper UI execution on the Swing thread. I pushed the code directly to your branch. Thanks for helping us fix this rather annoying bug! 🙂

@SiboVG SiboVG linked an issue Mar 13, 2025 that may be closed by this pull request
@SiboVG SiboVG merged commit ea295eb into openrocket:unstable Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Focus rocket config dialog when opening a file

3 participants