[#2664] Additional rocket properties #2693
Conversation
TODO: optimizations yet to be saved
Added additional properties such as "Design Type", as well as optimizations (Flight, Appearance, Construction). Functionality that saves these properties is also added.
|
Have yet to add conditional text field(s) for adding Kit name(s) but this first draft has almost all functionality ready. |
SiboVG
left a comment
SiboVG
left a comment
There was a problem hiding this comment.
Thanks for the changes @MiguelECL! I haven't tested this yet, but looking at the code, I added some remarks.
A general remark is that I'm not a fan of the Optimization settings. It makes it look like selecting either of these options makes a change to the program, which it clearly doesn't. I would not include this functionality yet until we actually do something useful with it, otherwise it just gets confusing. We could also add a warning message, but that's just extra clutter. We don't need the optimization property. Pinging @neilweinstock.
core/src/main/java/info/openrocket/core/rocketcomponent/Rocket.java
Outdated
Show resolved
Hide resolved
swing/src/main/java/info/openrocket/swing/gui/configdialog/RocketConfig.java
Outdated
Show resolved
Hide resolved
swing/src/main/java/info/openrocket/swing/gui/configdialog/RocketConfig.java
Outdated
Show resolved
Hide resolved
Fix for variables that were not camelCase, reverted wildcard imports, String[] options now uses translation keys.
|
Should I remove the "Optimization" properties completely or leave them commented for further development? |
|
I won't have a chance to test this code for a little while... screenshots would be helpful. This is all in service to the need for sites such as RocketReviews to be able to slurp up OR files and extract useful metadata. It is also "nice to have", even if most folks won't fill it in, and it doesn't hurt to have extra unused fields that are almost never visible to the user. The "Optimization" parameter originally proposed is exactly as implemented on RocketReviews. I am unsure of the best way to implement it within the program (as discussed in the original github issue), and would not object to simply deferring it until we can properly figure it out. If this were earlier in the release cycle I would say "go for it" and we'll clean it up before release, but since we're in the 11th hour (and 58 minutes) it's probably best not to insert something half-baked. I would be fine with leaving it commented for further development, even if it's possible that we will never follow up on it. Oh, and thanks for the contribution!!! |
As Neil also states, I would comment it out. |
…sed on "designType" When user selects a designType different from "Original Design", a text Area pops up allowing the user to write kit name
|
Have to resize the dialog when the text field for the kit name(s) appears, as users have to do it manually right now. |
The "Rocket Config" dialog now automatically resizes whenever the "kit name" field is rendered.
|
I have modified the code to make the saving of the design type independent of the translation key. This ensures that when files are distributed to users with different language settings, the design type loading still works. The rest looks good, thanks a lot for the change @MiguelECL! |
3 participants
Added additional properties such as "Design Type", as well as optimizations (Flight, Appearance, Construction). Functionality that saves these properties is also added. Fixes #2664