Skip to content

[#2662] Add File->Properties Menu #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SiboVG merged 3 commits into from
Jan 25, 2025
Merged

[#2662] Add File->Properties Menu #2686

SiboVG merged 3 commits into from
Jan 25, 2025

Conversation

@MiguelECL
Copy link
Contributor

@MiguelECL MiguelECL commented Jan 24, 2025 •
edited by SiboVG
Loading

Added the "Properties" menu item in the "File" parent menu. Clicking on properties allows editing on the Rocket properties such as design name, designer, etc. Fixes #2662.

@MiguelECL
[#2662] Add File->Properties Menu
bd0b560 
Added the "Properties" menu item in the "File" parent menu. Clicking on properties allows editing on the Rocket properties such as design name, designer, etc.
@SiboVG SiboVG linked an issue Jan 25, 2025 that may be closed by this pull request
Add File -> Properties menu item #2662
Closed
@SiboVG
Copy link
Member

SiboVG commented Jan 25, 2025

Thank you for the change @MiguelECL! Some small recommendations:

  1. I would move the menu item to above the "Close design" item because the top menu item group already has a lot of items, and in other software the Properties option is often lower in the dropdown list (from my experience)
image
  1. Change the shortcut to Ctrl/Cmd + i, I feel like this is easier than the Ctrl/Cmd + ^ shortcut. Alt + Enter is another often used shortcut for File Properties on Windows and Linux, but I prefer Ctrl/Cmd + i.

@SiboVG
Copy link
Member

SiboVG commented Jan 25, 2025

Thanks for the changes @MiguelECL, appreciate it!

@SiboVG SiboVG merged commit 42ab6f1 into openrocket:unstable Jan 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add File -> Properties menu item

2 participants

@MiguelECL @SiboVG