[#2626] Initialize CG in SymmetricComponent #2629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue for 0-length transitions that got loaded from the .ork file. The Transition was created, which initialized the CG to null. Then calculateProperties() was called on the Transition, which first goes to calculateProperties() of SymmetricComponent, but because the length is 0, the method immediately returned, leaving the CG to null, and causing the NullPointerException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2626. There was an issue for 0-length transitions that got loaded from the .ork file. The
Transitionwas loaded, which initializes the CG tonull. ThencalculateProperties()was called on theTransition, which first goes tocalculateProperties()ofSymmetricComponent, but because the length was 0, the method immediately returned, leaving the CG tonull, and causing theNullPointerException. This PR just initializes the CG incalculateProperties()ofSymmetricComponentso it cannot benull.