[#2614] Set transition component preset filled value based on actual preset value instead of the presence of the parameter #2615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this is a bit awkward. Transition (and nose cone) presets that had a
<Filled>parameter in the database, even if it was<Filled>false</False>, would always be set to filled, because ofloadFromPresetinSymmetricComponent.java:Which was called in
Transition:The result: all transition and nose cone presets that had a
Filledparameter in the database, which includes not all, but still a fair amount of parts, were incorrectly set toFilledand also had an incorrect mass (if no mass override was set).The
SymmetricComponentshould have checked the value of theFilledparameter (which can befalse). I have not found any component presets that did not explicitly define atrueorfalseFilledvalue, so I'm not sure where the original code originates from.Together with this PR fixes #2614 and fixes #2480.