[#2576] Fix Sorting Problem With Sides and Line Count columns on Parachute Preset Library #2578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoePfeiffer
requested changes
Oct 17, 2024
Contributor
JoePfeiffer
left a comment
JoePfeiffer
left a comment
There was a problem hiding this comment.
Thank you! Looks good.
One small thing is we do prefer to import the classes individually, rather than using a wildcard.
Contributor
Author
|
Fixed. |
JoePfeiffer
approved these changes
Oct 17, 2024
Member
|
Thanks for the change @stoopipoopy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2576 where the "Sides" and "Line Count" column in the Parachute Component panel sort lexically instead of numerically.
The problem was in ComponentPresetTable. During column initialization, the sorter did not have a special case for Integers as it did for Doubles and Booleans. This caused it to sort Integers like Strings instead of numbers because there was no base case other than the default.
The issue was fixed by adding a simple special case, just like the Booleans or Doubles, that handles Integers separately than all other Objects.