-
-
Notifications
You must be signed in to change notification settings - Fork 531
[#2485] Hide components #2511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2485] Hide components #2511
Conversation
|
Pretty slick. Not sure I've ever wanted this capability, but I can imagine some will find use for it. |
swing/src/main/java/info/openrocket/swing/gui/theme/UITheme.java
Outdated
Show resolved
Hide resolved
|
Just tested it, and it works great, great job @AhanuDewhirst! The code is also high-quality 👍 Maybe one suggestion: other programs often have a "Show all" button, which will show all hidden components (it should be disabled if no hidden components), even if they are not selected. |
|
Very nice indeed! @SiboVG it actually has hide all and show all buttons, attached to the stage and rocket. I like doing it this way; it seems to work well with our general tree structure. I wonder if the button names should just be Hide and Show, like everything else, though. One small issue is hiding a motor mount, stage or the entire rocket doesn't hide configured motor(s) in that component. @neilweinstock my use case for this is for complicated designs -- I sometimes find seeing just which component is selected to be difficult (possibly an issue for another time). Toggling visibility a couple of times helps me find it. |
|
Fine with me! Not every feature is for everyone. |
Sure, it has a "Hide all" option in the stage and rocket, but there is no way to simultaneously show all components in the design that are hidden. I'd like this feature for the scenario where a user has accidentally hidden one or more components and doesn't know how to revert this. The "Show all in design" button in the edit dialog could prevent this. If there's one thing I've learning while working on OR, it's no never overestimate your users. |
Maybe we should change the current "Show all" text to "Show selected", to reduce confusion with the "Show all in design" button. |
Checking... if I hide a component, then hide the stage, then show the stage, the hidden component is now visible (along with everything else, of course). Might be easier for the user if the hide/show stage and rocket buttons were "show" if any subcomponents were hidden, only "hide" if all the subcomponents are visible?
Good point! |
|
Hi all. Here are my thoughts on the topic: Firstly, thank you @SiboVG and @JoePfeiffer for your input and feedback. It's helped me reconsider the logic from an end-user perspective. I'm now taking a scenario-based approach to hopefully ensure the functionality is consistent and intuitive. These are the scenarios I've considered, and the visual feedback I'd expect as a user:
From an implementation perspective, I've separated behaviour from feedback: Behaviour
Feedback
Also note, hiding a motor mount now hides configured motors, and "Show all" is enabled in the Edit menu when any component is hidden. Let me know what you think! |
|
Very nice work -- thank you for your contribution to OpenRocket! |
|
Thanks a bunch @AhanuDewhirst, we really appreciate your contribution! 🙂 If you ever feel bored, be sure to check out some of the other open issues 😉 |
This PR fixes #2485 by allowing component visibility to be changed in the component tree via the Edit and Context menus.