Cleanups to component database directories; more robust manufacturer search #2481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix of the legacy components (which are also present in core/src/main/resources/datafiles/components-openrocket/) and obsolete versions of files from the database
…rnal and .../components/database respectively for better organization
…son no matter what order the parts databases are loaded. Replace string equals with Manufacturer match method when searching for parts in the database
…nce to presets directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to moving component directories around a little bit and getting rid of the obsolete presets directory, adds LOC/Precision to the Manufacturer list so it will always appear as "LOC/Precision" (instead of sometimes as "LOC Precision" depending on the order of database loading), and also uses the Manufacturer.matches() method instead of a string comparison to match a manufacturer name.
Fixes #2479