[#2444] Add Constrained Delaunay Triangulation for OBJ exporting #2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures correct normals, even for e.g. freeform fins of which the 3 first vertices are concave
SiboVG
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2444 by supporting Constrained Delaunay Triangulation (CDT) for exporting OBJ objects. Previously, a rudimentary triangulation method was implemented, which worked fine in most cases, but could cause issues for non-conventional fin shapes. The CDT is performed using the Java Topology Suite (JTS) library.
Since CDT is more robust than the simple triangulation, it is selected by default. However, it is more computationally intensive, so you can still choose to use simple triangulation in the OBJ export settings:
Result with simple triangulation:
Result with CDT:
