Don't consider shoulders in applying parallel axis theorem to longitudinal moment of inertia #2368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theorem to longitudinal inertia, as they aren't included in calculation of longitudinal inertia itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shoulders are not considered in computing moments of inertia in SymmetricComponent, but were considered in computing CG when applying the parallel axis theorem at the end of the calculation. This results in an inaccurate longitudinal moment of inertia, which could even become negative (there was code clamping the result to avoid that).
This PR fixes the bug in the sense that the code now does what the original author intended, but the shoulders should really be considered in moment of inertia calculations.
Fixes #2278