[#2217] Fix mass issues for fin sets (+ CM of launch lug and rail buttons) #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Functions as expected, no anomalous behavior found. OR Build: 1760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2217. The was caused by PR #2053 - I didn't realize that componentVolume was that of all the instances instead of a single instance.
Additionally, I noticed an issues with launch lugs and rial buttons where the y and z location of the CG wasn't right. If you created a new design with just a body tube and rail button/launch lug and overdid the mass of the body tube to 0, the CG should be located solely at the rail button/launch lug, which wasn't the case. This is now fixed.