[#2158] Add ok/cancel button for simulation editing #2163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The cancel button applies the (1) change to the launch rod length; (2) always launch up or down wind check box. |
Member
Author
Fixed now. This was actually a pre-existing bug, where setting the launch rod length or launch into wind boolean did not fire a change event. |
Collaborator
|
Functions as expected, no anomalous behavior found. OR Build: 1682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuation of #2149, so merge that first. It fixes #2158 by adding an ok/cancel button in the simulation edit dialog, similar to what is present for component editing.
Changes:
Demo:
Screen.Recording.2023-03-30.at.04.12.15.mp4
NOTE: this PR could be improved upon once #1391 is implemented.