Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Mar 28, 2023

This PR fixes #2148 and fixes #1826. Now, when closing the edit sim dialog in any way (clicking the close button, hitting the escape key, x-button in top-left of the window) applies the simulation options to all selected simulation.

The fix for #1826 is that multi-sim editing had some gaps, namely:

  • The checkbox for "Always launch directly up-wind"
  • The checkbox for "Use ISA"
  • Geodetic calculations

These are now fixed.

@SiboVG
Copy link
Member Author

SiboVG commented Mar 28, 2023

Oh, and now the edit button for sims is enabled, also when multiple sims are selected (fixes #2140).

@hcraigmiller
Copy link
Collaborator

Functions as described with no anomalous behavior found.

I do have one concern. If a change is accidental, there is no way to cancel that change. I would have the esc key cancel the changes, rather than confirm the changes.

OR Build: 1673
Microsoft Windows 11 Pro; 10.0.22621 Build 22621.1105; Windows Feature Experience Pack 1000.22638.1000.0
Java(TM) SE Runtime Environment 18.9 (build 11.0.18+9-LTS-195)

@SiboVG
Copy link
Member Author

SiboVG commented Mar 29, 2023

I do have one concern. If a change is accidental, there is no way to cancel that change. I would have the esc key cancel the changes, rather than confirm the changes.

I get your point, but that would be counter-intuitive to the workflow of component editing, where pressing the escape key also applies the changes. I'm also very much used to this workflow from other software, as I don't always want to move my mouse over to the close button and click it. Pressing the escape key just accelerates my workflow + it's aligned to the component edit workflow.

@neilweinstock
Copy link
Contributor

Ultimately we could have a cancel/OK button like in the component editor.

@hcraigmiller
Copy link
Collaborator

I do think something is needed to cancel an accidental change, perhaps as @neilweinstock suggested.

@SiboVG SiboVG merged commit 556522c into openrocket:unstable Mar 30, 2023
@SiboVG SiboVG deleted the issue-2140 branch March 30, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants