[#2102] Add "Select components of same color" and "Select none" option #2129
Conversation
|
Functions as described with no anomalous behavior found. NOTE: As stated above, The reference color is that of the highest selected component in the componenet tree (from top down), not the color of the highest number of components selected with the same color. QUESTIONS: @neilweinstock is probably the best qualified to answer those, though, if two selected tubes are red and one has a decal (transparent or otherwise) and the other does not, then changing the color to blue should change both tubes to blue, notwithstanding that one has a decal and the other does not. OR Build: 1636 |
|
Sorry I won’t be able to test this tonight but I can comment.
If you wanted to get fancier and make it available only if all the currently selected components already have the same color, that would be fine because then there would be no confusion or surprise. But it’s not necessary. |
|
Okay, same color selection is now only activated when one component is selected. |
|
Awesome. I will try this out as soon as it finishes building. |
|
Very nice. Two small issues:
Of course, putting the two new items in the top level menu would cause it to become very wide due to "Select components of same color", and I don't have a proposal to shorten that. And so I'm going to approve this for now, but as soon as we come up with a better menu organization we should change it. |
They don't. I pushed a commit to only enable the item if the component has an appearance section.
I actually see a deselect item (if present) under a select menu quite often. For example Adobe Illustrator: Blender: My idea for putting it in a separate select menu was that in the future we may add other selection modes that could be put there. Just helps organize things, I can't stand it when things aren't properly grouped together (flashbacks to horrific desktop organization I've seen with some people). I agree that the "None" is not used that often, so I'll change it to "Deselect all". |
|
Is the color selection no longer functional?
|
That's strange... it works for me: Did you do any special actions beforehand? |
Fair. I don't think that what we have is exactly analogous to those programs, but in any case I'm OK with it for now. Thank you for implementing this. |
|
Steps:
|
|
That is correct behavior. Select components of same color now only applies when a single component is selected. |
|
I see, I see... in that case, functions as described with no anomalous behavior found. OR Build: 1653 |
3 participants
This PR fixes #2102 and adds an option to "Select components of the same color" and to "Deselect components" in the edit application ribbon and the component context menu. #2102 was a request for the same color selection, but I thought there is probably a good majority of people that don't know how to properly deselect components.
Note: if a component has the default appearance, using the "Select components of the same color" will select all components of the same type that have the default appearance. E.g. selecting a body tube with default appearance and using the select of same color function will only select body tubes with the default appearance.
Demo:
Screen.Recording.2023-03-20.at.23.04.29.mp4
A question remains: what to do if the component has a decal? Should the "Select all components of same color" also check whether other components have the same color and the same decal? If the current component does not have a decal, but another component has a decal, but the same color, should that component be selected?
Another question: currently, the first selected component is used for the target color. So if you select multiple components, only the first component is considered. Should a more intelligent system be used that checks if a component has the same color as any of the selected components? E.g. you multi-select a red and blue component, clicking "Select all components of same color" will select all red and blue components.