Fix base drag #2119
Merged
Fix base drag #2119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Functions as described with no anomalous behavior found. OR Build: 1620 |
Resolve merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying problem causing issue #2118 is that the base drag calculation loop in BarrowmanCalculator compares each SymmetricComponent's forward radius to the preceding component's aft radius, and then calculates the preceding component's base drag. In addition to requiring a special case for the final SymmetricComponent, it's also unclear which resulted in the bug.
This PR rewrites that loop, so each SymmetricComponent compares its aft radius to the forward radius of the component behind it, and sets its own base CD. This reduces the special case handling to just noticing whether there is no next component and treating its forward radius as 0 if not, and also fixes #2118.
Also adds a unit test.