Properly load simulation data from saved simulations #2070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e can still have summary data
…ED if it has data, and NOT_SIMULATED if it doesn't. This is more reliable than the status attributed, as that gets saved as notsimulated when only summary data is saved. Also clean up logic in Simulation constructor a bit,
… from external sources -- do we actually have a way to load data from external sources?) and appropriate tooltip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out the old code never loaded sim summary data; the one row I thought had done so in the original bug report had actually been automatically re-run when I loaded the sim (which may be a bug itself, but if it is it isn't the same bug)
This PR fixes it by:
Note this doesn't address the desire to change the wording of the "save primary figures" option in the data save dialog. That will come when I fix #2024.
Fixes #2067