[#1617] Mark empty stages as inactive #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more reliable as it takes other factors into account (e.g. if the stage has no children)
Collaborator
|
Functions as expected, no anomalies found. Build 1037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1617 by marking empty stages as inactive. This is reflected in the stage selector buttons as a disabled button, which also indicates to new users that something is wrong with that stage. To make it even more clear, I added a tooltip text for the stage selector buttons for an empty stage: "This stages does not have any child components and is therefore marked as inactive. Add components to the stage to activate it.", and for a non-empty stage: "Toggle this button to activate or deactivate the corresponding stage in your design.".
Demo:
Screen.Recording.2022-09-20.at.23.19.13.mp4