[#1676] Treat zero-length SymmetricComponent as tube/disk #1677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Functions as expected, no anomalies found. This should definitely reduce the number of discontinuity errors related to Estes engine hook hacks.
Build 1031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1676 by setting the longitudinal and rotational inertia of a SymmetricComponent (transition/nose cone) to zero if the component length is zero. To then have the same behavior as a phantom body tube (the component acts as a disk and can still cause drag), I match the fore and aft radius to the max value of the two when the component length is zero. This is because a zero-length transition is just a disk, and a disk is just a zero-length tube. So matching the fore and aft radius will let the transition behave like a zero-length tube.