[#1662] Fix scaling of pod axial offset + fix ThicknessRingComponent scaling down #1674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Functions as expected, no anomalies found. Build 1024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1662. The issue was in the scaling order, whereby the parent component of the pod was scaled first, and then the pod (and its offset). This caused the parent reference length for the axial offset to change first, and the scaled axial offset to be calculated incorrectly. This PR first does all the component offset scalings, and only then the component dimension scalings.
I also noticed the same issue as #1653, but for ThicknessRingComponents (e.g. TubeCoupler), which this PR fixes.