Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Sep 6, 2022

This PR fixes #1646. Turns out the fin root points resolution of 2.5 mm was too small. Increasing it to 5 mm appears to have solved the issue.

So fin template export will be slightly less smooth (see discussion here).

@SiboVG
Copy link
Member Author

SiboVG commented Sep 7, 2022

See testing of @hcraigmiller in #1646.

If you scale the rocket 200% (fin tabs and no fin tabs), this is what happens with the parachute and fins:

Tab 200
Tab 200 Parachute

As to the parachute, current unstable does the same thing, I'll create a new parachute issue?

Build 992

[Windows 11 Pro; Version 21H2; OS Build 22000.739; Windows Feature Experience Pack 1000.22000.739.0]
[Java "11.0.15" 2022-04-19 LTS; Java(TM) SE Runtime Environment 18.9 (build 11.0.15+8-LTS-149)]

Originally posted by @hcraigmiller in #1646 (comment)

@SiboVG
Copy link
Member Author

SiboVG commented Sep 7, 2022

Okay, turns out that if the root has too many points, the 3D geometry can't handle it. So now, the number of root points is limited to 20 points instead of 100, but the default resolution is set to 2.5 mm (as was before this PR). So for small fins, you should still get a smooth fin geometry (2.5 mm resolution, if the root length is 5 cm or smaller). If the root length is larger than 5 cm, then there will only be 20 points for the root geometry.

@SiboVG
Copy link
Member Author

SiboVG commented Sep 7, 2022

Basically the 3D rendering of the fin should be replaced with drawing the fin using triangles. Unless that is fixed, I'll have to limit the root points...

@SiboVG
Copy link
Member Author

SiboVG commented Sep 7, 2022

Okay, new approach: I'm now using a special low-res root geometry only for the 3D rendering, so the rest of the program is not affected by the limitations in the 3D rendering.

@hcraigmiller
Copy link
Collaborator

Still occurs with a variety of back-to-back scaling, but the one that works every time is (1) scale 50% the (2) scale 1000%.

@SiboVG
Copy link
Member Author

SiboVG commented Sep 7, 2022

Still occurs with a variety of back-to-back scaling, but the one that works every time is (1) scale 50% the (2) scale 1000%.

No need for the back-to-back scaling; the 3D render just fails if the rocket is too large (if you scale it directly to 1000%). I can "fix" it by lowering the resolution even more, to 15 points for the 3D render... Given that the 3D view on curved parent shapes didn't work at all prior to the PR that caused #1646, I can live with the fact that in 3D views, the root geometry is only limited to 15 points. Maybe there's a better fix than just decimating the root geometry, but I'm not up for finding it atm.

Because otherwise you would still get 3D issues on large rockets
@hcraigmiller
Copy link
Collaborator

Functions as expected, no anomalies found.

Build 998

[Windows 11 Pro; Version 21H2; OS Build 22000.739; Windows Feature Experience Pack 1000.22000.739.0]
[Java "11.0.15" 2022-04-19 LTS; Java(TM) SE Runtime Environment 18.9 (build 11.0.15+8-LTS-149)]

@SiboVG SiboVG merged commit bf08a88 into openrocket:unstable Sep 10, 2022
@SiboVG SiboVG deleted the issue-1646 branch September 30, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fin 3D appearance goes transparent on non-conical transitions

2 participants