Skip to content

[#411] Improvements to scale dialog #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SiboVG merged 2 commits into from
Aug 14, 2022
Merged

[#411] Improvements to scale dialog #1589

SiboVG merged 2 commits into from
Aug 14, 2022

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Aug 14, 2022

This PR fixes #411 by displaying the scale dialog error message in terms of the currently selected unit + the spinner widgets now have a larger width.

@hcraigmiller
Copy link
Collaborator

hcraigmiller commented Aug 14, 2022

Functions as expected, no anomalies found.

  1. Scaling to apply window > 3 digits: Functions as expected
  2. Scale from and to windows > 1 digit: Functions as expected
  3. Recenter the rocket in the window: Functions as expected
  4. Unable to trigger scale factor error.

Build 888
[Windows 11 Pro; Version 21H2; OS Build 22000.739; Windows Feature Experience Pack 1000.22000.739.0]
[Java "11.0.15" 2022-04-19 LTS; Java(TM) SE Runtime Environment 18.9 (build 11.0.15+8-LTS-149)]

@SiboVG SiboVG merged commit 8b91342 into openrocket:unstable Aug 14, 2022
@SiboVG SiboVG deleted the issue-411 branch September 30, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the Scale Dialog

2 participants

@SiboVG @hcraigmiller