Skip to content

[#1305] Bigger default preset window size + remember column width #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SiboVG merged 1 commit into from
Aug 19, 2022
Merged

[#1305] Bigger default preset window size + remember column width #1583

SiboVG merged 1 commit into from
Aug 19, 2022

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Aug 13, 2022

This PR fixes #1305 by adding the following changes to the preset dialog UI:

  • By default larger window size (based on the size of BasicFrame - the main OR window)
  • Rememberance of window size and location
    • The window size and location is the same for the preset dialogs accross all component types. If you change the dialog size in the body tube preset dialog, then that same window size will be used for the nose cone preset dialog. Seems like the most reasonable approach to me.
  • Rememberance of column widths
    • This is custom for each different preset dialog. Changing e.g. the width of the second column in the body tube dialog does not alter the second column width in the nose cone preset dialog.

Demo:

Screen.Recording.2022-08-13.at.15.35.28.mp4

@neilweinstock
Copy link
Contributor

neilweinstock commented Aug 13, 2022

You're spoiling me.

Are these settings remember for each rocket design or globally for the program? (Globally would be the best choice here).

@hcraigmiller
Copy link
Collaborator

hcraigmiller commented Aug 13, 2022

Functions as described, no anomalies found. A really nice improvement.

Build 884
[Windows 11 Pro; Version 21H2; OS Build 22000.739; Windows Feature Experience Pack 1000.22000.739.0]
[Java "11.0.15" 2022-04-19 LTS; Java(TM) SE Runtime Environment 18.9 (build 11.0.15+8-LTS-149)]

@SiboVG
Copy link
Member Author

SiboVG commented Aug 13, 2022

You're spoiling me.

Are these settings remember for each rocket design or globally for the program? (Globally would be the best choice here).

The settings are global.

@SiboVG SiboVG merged commit 68fe643 into openrocket:unstable Aug 19, 2022
@SiboVG SiboVG deleted the issue-1305 branch September 30, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remember column widths and window size in parts database dialogs (and/or provide better defaults)

3 participants

@SiboVG @neilweinstock @hcraigmiller