[#1558] Restore focus to motors, recovery, stage and simulation table after table action + others #1563
Conversation
(I'm doing this for a later commit I will push in this PR)
Move DesignPanel into separate file
# Conflicts: # swing/src/net/sf/openrocket/gui/main/BasicFrame.java # swing/src/net/sf/openrocket/gui/main/SimulationPanel.java
|
Focus is not restored after running a simulation. Unexpected Behavior
Other behaviors:
Overall, I believe these changes are looking very helpful. Build 845 |
Fixed with the latest commits
Also fixed with the latest commits
Still working on this one Thanks for the thorough testing! |
Should now be fixed in the latest commit. Behavior, with the example scenario of first being in the motors config tab:
|
|
As to the Motor and Configuration tab and sub-menus, functions as described and expected, no anomalies found. But, as between the Motor and Configuration tab and Flight simulations tab, changes on the Motor and Configuration tab sub-menues causes the flight simulation focus to shift. Follow these steps:
It may be able to be done with fewer steps, but the above seems to cause it every time. Is this part of this PR or a new issue? Build 851 |
|
Works beautifully. No anomolies found. This is a really nice improvement. Build 853 |
|
Well there's still one bug: highlighting a stage's components is broken, but I'm working on it. |
|
I'm not seeing that. How is it triggered? |
If you open for example 'A simple model rocket', when you select the sustainer in the component tree, all the components in the design view should be selected, which is now not the case anymore. |
|
I see that now. The same is true if you select the entire rocket. |
|
Using three-stage rocket example.
No other anomalied found. Build 854 |
Working on it... |
|
Unexpected bahvior persists [Using three-stage rocket example].
Build 859 |
Yes, my last commits are not commits that fix that issue ;) I just pushed those commits because I was about to do some git stuff that made it more difficult to retrieve my changes if I did not first push my commits to my repo. |
|
Also: said issue is already present in beta 4 (so not a direct result of this PR). |
|
In all other ways, functions as expected, no anomalies found. Build 859 |
Should be fixed now |
|
All of the testinf went flawlessly until I started entering actual settings to see what effect it would have on the simulation outcomes. Then I got this:
I can replicate it, but just by fiddling around, no verifiable steps yet. ---------- Bug report ---------- Please include a description about what actions you were performing when the exception occurred: Include your email address (optional; it helps if we can contact you in case we need additional information): (Do not modify anything below this line.) ---------- Thread information ---------- ---------- System information ----------
100702 479.551 INFO (BasicEventSimulationEngine.java:293) Queueing Ignition Event for: Inner Tube/9c7c8b9f / B6 - Armed @: 0.857 101334 479.583 INFO (BasicEventSimulationEngine.java:293) Queueing Ignition Event for: Inner Tube/6b229a52 / A8 - Armed @: 1.7151763645050002 101388 479.583 INFO (BasicEventSimulationEngine.java:293) Queueing Ignition Event for: Inner Tube/6b229a52 / C6 - Armed @: 1.71561675922274 103531 479.630 INFO (BasicEventSimulationEngine.java:90) >>Starting simulation of branch: Sustainer 106876 479.692 INFO (BasicEventSimulationEngine.java:96) <<Finished simulating branch: Sustainer curTime:125.93488625925275 finTime:125.93488625925275 108711 479.724 INFO (BasicEventSimulationEngine.java:96) <<Finished simulating branch: Booster stage curTime:12.32888317622233 finTime:12.32888317622233
|
|
Thanks for testing... Fixed in the last commit. |
|
Christ, this has been a tough one to get out. Again, thanks for stress testing it @hcraigmiller |
|
Functions as expected, no anomalies found (using three-stage rocket example).
Build 883 |
|
To boil this long PR thread down, here's a summary of what this PR changed (in case @neilweinstock wants to give it a final check):
Just took a while to get there bug-free 🙃, hence the lengthy discussion. Demo: Screen.Recording.2022-08-22.at.12.30.26.mp4 |
|
Just put it through its paces... this is wonderful. Nice job. And thanks also to @hcraigmiller for sticking with it on testing this one. |
3 participants
This PR fixes #1558 by restoring focus to the motors, recovery, stage and simulation table after a table action (e.g. after resetting the motor ignition or removing a configuration).
While working on this PR, I also implemented two new things, one thing that should have been there for a long time, and another that may need some approval.
2.1. If you are in the rocket design tab and switch to the motors & config tab, and the Motors tab is selected, the motor configurations table will gain focus. If the recovery tab would have been active previously, the recovery table would have gained focus. Analogous behavior for the stage config.
2.2 If you switch to the sim tab, the sim table will gain focus.
The second change I'd like feedback on. It was something I felt makes sense: switching to a certain tab puts focus on the GUI element that you will be working in.