Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Jul 20, 2022

This PR fixes #1539: double clicking a row in the preset selection dialog will now apply that preset to the component and close the preset window. Double clicking the first column is not included in this behavior (since this is a checkbox).

I also did some cleanup of translation keys on the way.

@hcraigmiller
Copy link
Collaborator

Functions as described, no anomalies found.

Build 822
[Windows 11 Pro; Version 21H2; OS Build 22000.739; Windows Feature Experience Pack 1000.22000.739.0]
[Java "11.0.15" 2022-04-19 LTS; Java(TM) SE Runtime Environment 18.9 (build 11.0.15+8-LTS-149)]

@SiboVG
Copy link
Member Author

SiboVG commented Aug 2, 2022

@neilweinstock or @JoePfeiffer, a final LGTM for this functionality?

@JoePfeiffer JoePfeiffer merged commit 5fb93cb into openrocket:unstable Aug 2, 2022
@SiboVG SiboVG deleted the issue-1539 branch September 30, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: let double-click in preset dialog apply that preset

3 participants