Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Jun 27, 2022

This PR fixes #1490 and selects the recovery device/stage in the design view corresponding to the selected recovery device/stage in the recovery/stage configuration table.

Demo:

Screen.Recording.2022-06-27.at.22.26.23.mov

This PR also fixes o an issue with #1494 where selecting multiple stages had no effect on the design view.

@hcraigmiller
Copy link
Collaborator

hcraigmiller commented Jun 27, 2022

Number of issues/questions.

Open Three-stage rocket example.

Select Motors & Configuration and Motors tab... upper stage still selected... left-click configuration to select motor... turn off any stage to error.
01 01 Motor

Select Motors & Configuration and Recovery tab... upper stage still selected... left-click configuration to select depolyment device... turn off any stage to error.

02 01 Recovery

Select Motors & Configuration and Stage tab... upper stage still selected... left-click configuration to select stage... turn off any stage to error.

03 01 Stage

Attempting to add a recovery device... actually any component... to the designs causes error.

04 01 Parachute

Reaper.Small.ork.txt

Build 764
[Windows 11 Pro; Version 21H2; OS Build 22000.739; Windows Feature Experience Pack 1000.22000.739.0]
[Java "11.0.15" 2022-04-19 LTS; Java(TM) SE Runtime Environment 18.9 (build 11.0.15+8-LTS-149)]

@SiboVG SiboVG marked this pull request as draft June 27, 2022 22:12
@SiboVG
Copy link
Member Author

SiboVG commented Jun 27, 2022

Ouch, sorry, didn't encounter those issues, will push a fix soon.

@SiboVG
Copy link
Member Author

SiboVG commented Jun 27, 2022

Select Motors & Configuration and Motors tab... upper stage still selected... left-click configuration to select motor... turn off any stage to error.

This is intentional, the motor mount is only selected when the motor table has gained focus. That ensures that the component selection does not always change when you switch to the 'Motors & Configuration' tab. So only an active click in the table triggers the component select, as it should be.

@SiboVG SiboVG marked this pull request as ready for review June 27, 2022 23:01
@SiboVG
Copy link
Member Author

SiboVG commented Jun 27, 2022

Does the final commit fix the issues @hcraigmiller?

@hcraigmiller
Copy link
Collaborator

Functions as described by @SiboVG above, no anomalies found.

Build 766

[Windows 11 Pro; Version 21H2; OS Build 22000.739; Windows Feature Experience Pack 1000.22000.739.0]
[Java "11.0.15" 2022-04-19 LTS; Java(TM) SE Runtime Environment 18.9 (build 11.0.15+8-LTS-149)]

@SiboVG
Copy link
Member Author

SiboVG commented Jun 27, 2022

Functions as described by @SiboVG above, no anomalies found.

Phew. Thanks for catching the initial bugs!

@SiboVG SiboVG merged commit 3444a96 into openrocket:unstable Jul 4, 2022
@SiboVG SiboVG deleted the issue-1490 branch September 30, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: select recovery device/stage in design view when selected in recovery/stage configuration tab

2 participants