Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Jun 27, 2022

This PR fixes #1489 by visually selecting all children of a selected rocket, stage/booster or podset. It only visually selects the components, meaning that if you click the edit button, only the stage/rocket/podset will be edited, not the children (because only the stage/rocket/podset is selected in the componenttree). Right-clicking in the design view will also visually deselect all the components and then (single-component) select the component that is right-clicked upon.

Again, a lot of words, here's a demo:

Screen.Recording.2022-06-27.at.01.52.44.mp4

Also works in the 3D view:

Screen.Recording.2022-06-27.at.02.04.51.mp4

@neilweinstock
Copy link
Contributor

I like it.

It doesn't apply to children of body tubes, right? That could be troublesome. For rocket/stage/podset I think this is great.

@SiboVG
Copy link
Member Author

SiboVG commented Jun 27, 2022

It doesn't apply to children of body tubes, right? That could be troublesome. For rocket/stage/podset I think this is great.

Yes, only applies to rocket/stage/podset, no other component types.

@hcraigmiller
Copy link
Collaborator

Works very well... so well in fact that it highlighted two design flaws in the Three-stage rocket example that need to be fixed (lower-stage couplers overlapping upper-stage centering rings). No anomalies found.

[Windows 11 Pro; Version 21H2; OS Build 22000.739; Windows Feature Experience Pack 1000.22000.739.0]
[Java "11.0.15" 2022-04-19 LTS; Java(TM) SE Runtime Environment 18.9 (build 11.0.15+8-LTS-149)]

@SiboVG SiboVG merged commit 10b1990 into openrocket:unstable Jun 27, 2022
@SiboVG SiboVG deleted the issue-1489 branch September 30, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: when stage selected, select all its components in the rocket design view

3 participants