-
-
Notifications
You must be signed in to change notification settings - Fork 532
[#1477 & #1460] Don't include inactive stages in calculations #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Latests commits should fix #1460, but I'm still in the process of writing unit tests for the new stage disabling behavior. |
Fixes a bug where if you delete the parent component of a booster set, it would throw a NullPointerException in BarrowmanCalculator.java:861
Because of the new behavior 'disable sub-stages when parent stage is disabled', some unit tests needed to be rewritten
|
Okay, everything should be up and running now, with unit tests confirming that the simulation results are correct. |
|
As to Issue #1477, functions as expected, no anomalies found. |
|
Forgot to mention: this PR also fixes #1460. |
|
Remember that you only get paid by the PR, so you don't gain by fixing too many issues at once. |
|
At to Issue #1460, first, let me say that everything functions as described with no anomalies. However, I'm not sure that turning off the sustainer, or turning off a mid stage (leaving an upper and lower stage on) should produce flight results where this cannot occur in real life and the results therefore incorrect. Thoughts from others? |
Also thought about it, but I think that's more of a "if something bad/unrealistic happens, that's on the user for inputting garbage", so not something we should account for. |

This PR fixes #1477 by not including inactive stages in calculateForceAnalysis.
Note: unintentionally this is already the start of fixing #1460, so I will leave this PR as a draft and add more commits as I go.