Skip to content

Conversation

@SiboVG
Copy link
Member

@SiboVG SiboVG commented Jun 24, 2022

This PR fixes #1477 by not including inactive stages in calculateForceAnalysis.

Note: unintentionally this is already the start of fixing #1460, so I will leave this PR as a draft and add more commits as I go.

@SiboVG SiboVG marked this pull request as draft June 24, 2022 00:16
@SiboVG
Copy link
Member Author

SiboVG commented Jun 24, 2022

Latests commits should fix #1460, but I'm still in the process of writing unit tests for the new stage disabling behavior.

SiboVG added 5 commits June 25, 2022 15:58
Fixes a bug where if you delete the parent component of a booster set, it would throw a NullPointerException in BarrowmanCalculator.java:861
Because of the new behavior 'disable sub-stages when parent stage is disabled', some unit tests needed to be rewritten
@SiboVG SiboVG marked this pull request as ready for review June 25, 2022 23:17
@SiboVG
Copy link
Member Author

SiboVG commented Jun 25, 2022

Okay, everything should be up and running now, with unit tests confirming that the simulation results are correct.

@hcraigmiller
Copy link
Collaborator

As to Issue #1477, functions as expected, no anomalies found.

@SiboVG
Copy link
Member Author

SiboVG commented Jun 25, 2022

Forgot to mention: this PR also fixes #1460.

@neilweinstock
Copy link
Contributor

Remember that you only get paid by the PR, so you don't gain by fixing too many issues at once.

@hcraigmiller
Copy link
Collaborator

hcraigmiller commented Jun 25, 2022

At to Issue #1460, first, let me say that everything functions as described with no anomalies.

However, I'm not sure that turning off the sustainer, or turning off a mid stage (leaving an upper and lower stage on) should produce flight results where this cannot occur in real life and the results therefore incorrect. Thoughts from others?

@SiboVG
Copy link
Member Author

SiboVG commented Jun 26, 2022

Remember that you only get paid by the PR, so you don't gain by fixing too many issues at once.

It's only because the fix from #1477 already started fixing #1460 that I continued the work.

@SiboVG
Copy link
Member Author

SiboVG commented Jun 26, 2022

However, I'm not sure that turning off the sustainer, or turning off a mid stage (leaving an upper and lower stage on) should produce flight results as this cannot occur in real life. Thoughts from others?

Also thought about it, but I think that's more of a "if something bad/unrealistic happens, that's on the user for inputting garbage", so not something we should account for.

@hcraigmiller
Copy link
Collaborator

There are some intricacies that will need to be documented for users, but I really like being able to see what effect each stage has on the flight.

Stages Rev_01

Functions as expected, no anomalies found.

@SiboVG SiboVG changed the title [#1477] Don't include inactive stages in calculations [#1477 & #1460,] Don't include inactive stages in calculations Jun 27, 2022
@SiboVG SiboVG changed the title [#1477 & #1460,] Don't include inactive stages in calculations [#1477 & #1460] Don't include inactive stages in calculations Jun 27, 2022
@JoePfeiffer JoePfeiffer merged commit 173b332 into openrocket:unstable Jul 6, 2022
@SiboVG SiboVG deleted the issue-1477 branch September 30, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants